append login to name #134
Merged
append login to name #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Lambrechts <jonathan.lambrechts@uclouvain.be>
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
========================================
+ Coverage 98.46% 100% +1.53%
========================================
Files 9 9
Lines 586 586
Branches 101 101
========================================
+ Hits 577 586 +9
+ Misses 8 0 -8
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
|
@ccorail I have added the German translation of the option. Can you fix the tests please? |
Signed-off-by: Jonathan Lambrechts <jonathan.lambrechts@uclouvain.be>
|
all tests are successful now |
|
@ccorail thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a simple commit adding an option to append the login to the password path. Useful if you naming scheme is website.com/login (which allows to have several account for the same website in a single repository).
The german translation of the option description is missing.