Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy passwords via gopass json api #147

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

kristiankostadinov
Copy link
Contributor

@kristiankostadinov kristiankostadinov commented Apr 17, 2020

Use the api to copy passwords (#49)

Signed-off-by: Kristian Kostadinov <kristian_kostadinov@yahoo.com>
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          590       589    -1     
  Branches       101       101           
=========================================
- Hits           590       589    -1     
Impacted Files Coverage Δ
web-extension/search.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ad0ca...bd9222a. Read the comment docs.

@kristiankostadinov kristiankostadinov marked this pull request as ready for review April 17, 2020 14:42
@Pharb Pharb self-requested a review April 17, 2020 16:56
Copy link
Member

@Pharb Pharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works well and code looks good. Checked in Chrome and Firefox.
Thank you very much @kristiankostadinov

@Pharb Pharb merged commit ef3efb9 into gopasspw:master Apr 17, 2020
@kristiankostadinov kristiankostadinov deleted the copy-password-via-api branch May 8, 2020 16:55
@Pharb Pharb added this to the 0.8 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants