Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in preparation of gopass 1.10 #166

Merged
merged 2 commits into from
Aug 16, 2020

Conversation

Pharb
Copy link
Member

@Pharb Pharb commented Aug 9, 2020

RELEASE_NOTES=Improve error handling for gopass 1.10 upgrade

Screenshot 2020-08-09 at 23 52 32

Screenshot 2020-08-09 at 23 06 20

Screenshot 2020-08-11 at 00 28 30

Screenshot 2020-08-11 at 00 28 36

Handle:

  • Native host has exited
  • Error when communicating with the native messaging host
  • An unexpected error occurred (=> strange Firefox behaviour, probably broken in the browser?)
  • Native application tried to send a message...

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          717       717           
  Branches       120       120           
=========================================
  Hits           717       717           
Impacted Files Coverage Δ
web-extension/popup.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f765c1...9358cba. Read the comment docs.

RELEASE_NOTES=Improve error handling for gopass 1.10 upgrade

Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
@Pharb
Copy link
Member Author

Pharb commented Aug 9, 2020

Part of #165

@Pharb Pharb mentioned this pull request Aug 9, 2020
10 tasks
RELEASE_NOTES=Improve error handling for gopass 1.10 upgrade

Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
@Pharb
Copy link
Member Author

Pharb commented Aug 16, 2020

Checked again with latest gopasspw/gopass@1ff797e master.

@Pharb Pharb merged commit 2404232 into master Aug 16, 2020
@Pharb Pharb deleted the gopass-error-handling branch August 16, 2020 23:07
@Pharb Pharb added this to the 0.8 milestone Aug 20, 2020
@lockejan
Copy link

RELEASE_NOTES=Improve error handling for gopass 1.10 upgrade

Screenshot 2020-08-09 at 23 52 32

Screenshot 2020-08-09 at 23 06 20

Screenshot 2020-08-11 at 00 28 30

Screenshot 2020-08-11 at 00 28 36

Handle:

  • Native host has exited
  • Error when communicating with the native messaging host
  • An unexpected error occurred (=> strange Firefox behaviour, probably broken in the browser?)
  • Native application tried to send a message...

Hey, how can I debug such errors? I'm currently facing "Native host has exited" and "Error when communicating with the native messaging host."

Dev-Tools are giving me:

DevTools failed to load source map: Could not load content for chrome-extension://kkhfnlkhiapbiehimabddjbimfaijdhk/vendor/browser-polyfill.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants