-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic auth support #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good in general to me. Some tests probably need to be written/adapted but it's far less complex than the passff implementation.
Also tested the functionality with some basic auth dialogs on ffx and it works fine. |
Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 469 526 +57
Branches 79 91 +12
=====================================
+ Hits 469 526 +57
Continue to review full report at Codecov.
|
Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
Signed-off-by: Patrick Harböck <patrick.harboeck@tngtech.com>
I added the remaining tests, this PR should be complete now IMHO. @martinhoefling When your review is done I think we can merge this to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
This adds support for request authentication as requested in #89 and #91 using https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/onAuthRequired.
A small workaround was required to support Chrome, see mozilla/webextension-polyfill#91.
Some manual test cases: