Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom JSON Unmarshaler: Improve formatting, presentation. #260

Merged
merged 2 commits into from Dec 8, 2017
Merged

Custom JSON Unmarshaler: Improve formatting, presentation. #260

merged 2 commits into from Dec 8, 2017

Conversation

dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Dec 8, 2017

This PR makes the following minor improvements:

  • Wrap code blocks to fit into a smaller width, as displayed on the blog.gopheracademy.com website, especially at smaller window widths.

  • Remove code tags from links, because blog.gopheracademy.com CSS makes it hard to tell they're links (they look just like non-link code fragments until you hover over them).

  • Include domain in link to neelance/graphql-go project for consistency.

  • Minor change in 25b3ea1 to improve consistency between example GraphQL query and its result.

/cc @bketelsen

Wrap code blocks to fit into a smaller width, as displayed on the
blog.gopheracademy.com website, especially at smaller window widths.

Remove code tags from links, because blog.gopheracademy.com CSS
makes it hard to tell they're links (they look just like non-link code
fragments until you hover over them).

Include domain in link to neelance/graphql-go project for consistency.
Just a small polish touch for fun, since the dimensions of
https://golang.org/doc/gopher/run.png image are 194x180.
@bketelsen bketelsen merged commit 89b7cce into gopheracademy:master Dec 8, 2017
@dmitshur dmitshur deleted the patch-1 branch December 8, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants