Skip to content

Commit

Permalink
TestPortsbindingCRUD: Fix order of arguments in equal assertions
Browse files Browse the repository at this point in the history
The correct order is `expected`, `actual`. Having this right helps
debugging since the values are printed in a log message.
  • Loading branch information
mandre committed Jan 2, 2024
1 parent 3c68a0f commit e707ba8
Showing 1 changed file with 8 additions and 8 deletions.
Expand Up @@ -40,9 +40,9 @@ func TestPortsbindingCRUD(t *testing.T) {
defer networking.DeletePort(t, client, port.ID)

tools.PrintResource(t, port)
th.AssertEquals(t, port.HostID, hostID)
th.AssertEquals(t, port.VNICType, "normal")
th.AssertDeepEquals(t, port.Profile, profile)
th.AssertEquals(t, hostID, port.HostID)
th.AssertEquals(t, "normal", port.VNICType)
th.AssertDeepEquals(t, profile, port.Profile)

// Update port
newPortName := ""
Expand Down Expand Up @@ -72,9 +72,9 @@ func TestPortsbindingCRUD(t *testing.T) {
th.AssertNoErr(t, err)

tools.PrintResource(t, newPort)
th.AssertEquals(t, newPort.Description, newPortName)
th.AssertEquals(t, newPort.Description, newPortDescription)
th.AssertEquals(t, newPort.HostID, newHostID)
th.AssertEquals(t, newPort.VNICType, "normal")
th.AssertDeepEquals(t, newPort.Profile, newProfile)
th.AssertEquals(t, newPortName, newPort.Description)
th.AssertEquals(t, newPortDescription, newPort.Description)
th.AssertEquals(t, newHostID, newPort.HostID)
th.AssertEquals(t, "normal", newPort.VNICType)
th.AssertDeepEquals(t, newProfile, newPort.Profile)
}

0 comments on commit e707ba8

Please sign in to comment.