Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of update snapshot operation #2066

Closed
TenSt opened this issue Dec 2, 2020 · 5 comments
Closed

Support of update snapshot operation #2066

TenSt opened this issue Dec 2, 2020 · 5 comments

Comments

@TenSt
Copy link
Contributor

TenSt commented Dec 2, 2020

Hi Gophercloud team.
I was going through crud operations of snapshots and I see that update is not there. There is update metadata, however no update for snapshot. There is an API call for this operation in OpenStack:
https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=#update-a-snapshot

I'm willing to work on contribution of it, but before starting wanted to know if there was some reason behind not covering it from the start? Is there some issue with it or it was just missed and I can work on contributing it?

Thanks,
Stepan

@jtopjian
Copy link
Contributor

jtopjian commented Dec 2, 2020

@TenSt Thanks for opening this issue. It looks like the update call was just overlooked and never added.

@TenSt
Copy link
Contributor Author

TenSt commented Dec 3, 2020

@jtopjian thanks. Then I will start working on contributing it. It may take some time as it would be my first contribution to gophercloud and I will be configuring local environment for the first time.

@jtopjian
Copy link
Contributor

jtopjian commented Dec 3, 2020

@TenSt No problem. Let me know if you need any help or have any questions.

@TenSt
Copy link
Contributor Author

TenSt commented Dec 20, 2020

@jtopjian
Sorry for the delay, I was really pinned down at work. Here is the PR, I hope I've covered everything: #2081

@TenSt
Copy link
Contributor Author

TenSt commented Dec 30, 2020

Closing, as the code was successfully merged and released in v0.15.0

@TenSt TenSt closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants