Block storage: adding support of update snapshot api call #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; changed receiver name from page to r in the NextPageURL func to be consistent over all funcs
…; updated comment in docs for tests
|
Build failed.
|
jtopjian
requested changes
Dec 21, 2020
There was a problem hiding this comment.
@TenSt Thanks! This all looks really good - really nice work. Just one small nit with the acceptance test.
You can ignore the OpenLab error. The failure is coming from an unrelated test.
Please let me know if you have any questions.
|
@jtopjian Thanks! I've done the change you requested. |
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2066
Links to the line numbers/files in the OpenStack source code that support the code in this PR:
API:
https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=update-a-snapshot-detail#update-a-snapshot
Schema:
https://github.com/openstack/cinder/blob/482e6a3cc5cca697b54ee1d853a4eca6e6f3cfc7/cinder/api/schemas/snapshots.py#L45
It seems that v3 uses the same method as v2 under the hood:
https://github.com/openstack/cinder/blob/482e6a3cc5cca697b54ee1d853a4eca6e6f3cfc7/cinder/api/v3/snapshots.py#L26
Update api:
https://github.com/openstack/cinder/blob/482e6a3cc5cca697b54ee1d853a4eca6e6f3cfc7/cinder/api/v2/snapshots.py#L148
Additional information:
Acceptance tests were ran against live OpenStack API(Ussuri). Here are logs from its run:
AcceptanceTestsRun_logs.txt