Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutron Ports: Add support for extra_dhcp_opts #511

Closed
fatmcgav opened this issue Sep 5, 2017 · 5 comments
Closed

Neutron Ports: Add support for extra_dhcp_opts #511

fatmcgav opened this issue Sep 5, 2017 · 5 comments

Comments

@fatmcgav
Copy link
Contributor

fatmcgav commented Sep 5, 2017

As requested in https://github.com/terraform-providers/terraform-provider-openstack/issues/99, the Ports package should support the extra_dhcp_opts param.

Further details on API available here: https://developer.openstack.org/api-ref/networking/v2/index.html?expanded=create-port-detail

@jtopjian
Copy link
Contributor

Additional work required: Locate where extra_dhcp_opts is defined in Neutron.

Bonus: add extra_dhcp_opts to an existing Port acceptance test and verify it works.

@ozerovandrei
Copy link
Contributor

Hey.
Can I take this one? #533 seems abandoned.
@bugosiphionah can I create a new PR for that issue?

@jtopjian
Copy link
Contributor

jtopjian commented Mar 1, 2018

@ozerovandrei If you don't hear back from @bugosiphionah in the next day, then I would say you can proceed with working on this.

@ozerovandrei
Copy link
Contributor

ozerovandrei commented Mar 4, 2018

Ok. I created some PRs. I've decided to implement it in a separate extension for the networking v2 package, because it's described as an extension both in a documentation and a code:

https://developer.openstack.org/api-ref/network/v2/
https://github.com/openstack/neutron/blob/stable/pike/neutron/extensions/extra_dhcp_opt.py

@jtopjian
Copy link
Contributor

jtopjian commented Mar 6, 2018

Implemented in #804

@ozerovandrei Thank you for your work with this 😄

@jtopjian jtopjian closed this as completed Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants