Add networking port extra DHCP opts Update call #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
Add a new networking v2 extension to provide extra DHCP configuration support for ports. Add basic structures with a unit test.
Use "ExtraDHCPOptsExt" and "ExtraDHCPOpts" for basic structs names of the extra dhcp options extenstion. Upgrade unit-test and fix spacing in the unit test fixture.
Move the extra DHCP options GET unit test to the standard networking port package.
Add a Create request to the networking v2 extra DHCP options extension. Add unit and acceptance tests.
Move the extra DHCP options Create call unit and acceptance tests to the standard networking port package.
Rename comment for the CreateOptsExt.ExtraDHCPOpts field.
Add an Update request to the networking v2 extra DHCP options extension. Add unit and acceptance tests.
ozerovandrei
force-pushed
the
feature/ports-dhcp-opts-update
branch
from
0fdbe48
to
3289c0e
Compare
|
Build succeeded.
|
|
@ozerovandrei This all looks good to me. There's one issue that I didn't catch yesterday: Rather than you make the change and then have to do a bunch of rebasing across all 3 PRs, I'm going to merge this PR (which contains all of the work) and then follow-up with my own commit to fix this. It's my fault I didn't catch the name and you shouldn't have to pay for it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an Update request to the networking v2 extra DHCP options extension.
Add unit and acceptance tests.
For #511
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-lib/blob/stable/pike/neutron_lib/api/definitions/extra_dhcp_opt.py#L25
https://github.com/openstack/neutron/blob/stable/pike/neutron/agent/linux/dhcp.py#L954
https://github.com/openstack/neutron/blob/stable/pike/neutron/db/extra_dhcp_opt/models.py#L20
https://github.com/openstack/neutron/blob/stable/pike/neutron/objects/ports.py#L266
https://github.com/openstack/neutron/blob/stable/pike/neutron/objects/ports.py#L320