-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix apiversions base URLs #1530
Conversation
@openstacker @MaysaMacedo: Total coincidence that you both contributed an It's very possible that you won't see this bug in environments that you have access to, but I'm confident that you will eventually get reports of failures. The following test has a list for all supported URL formats once this is merged: https://github.com/gophercloud/gophercloud/blob/master/openstack/utils/testing/base_endpoint_test.go |
Build failed.
|
efa186e
to
c796068
Compare
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/gophercloud/gophercloud/openstack/orchestration/v1/apiversions
# github.com/gophercloud/gophercloud/openstack/orchestration/v1/apiversions
openstack/orchestration/v1/apiversions/requests.go:10:32: undefined: apiVersionsURL
@jtopjian okay, thanks for letting us know. |
c796068
to
9891fd2
Compare
@ozerovandrei whoops - ok, should be good to go once OpenLab finishes. |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@ozerovandrei Thanks! |
For #1529
This commit updates the
apiversions
packages to account for a variety of base URLs which have been known to exist in the Keystone catalog: https://github.com/gophercloud/gophercloud/blob/master/openstack/utils/testing/base_endpoint_test.goThese packages should also be housed under a versionless directory. For example,
networking/v2/apiversions
should benetworking/apiversions
since it should be possible to use this package to retrieve the API versions for all major versions.However, there is a catch: services such as Block Storage changed the format of the API results a while back. this is why
blockstorage/v1/apiversions
exists. I fell down a rabbit hole looking into this a while back (#458). I haven't reviewed all of these packages to determine if there are other occurrences like this, so for now, the packages will stay where they are.