Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update port forwarding #1703

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Update port forwarding #1703

merged 5 commits into from
Sep 17, 2019

Conversation

simonre
Copy link
Contributor

@simonre simonre commented Sep 16, 2019 •
edited by jtopjian

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 16, 2019

Build failed.

@simonre
Copy link
Contributor Author

simonre commented Sep 16, 2019

@jtopjian I don't think the two failures here are due to problems with my code, this should be ready to review

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 76.865% when pulling a0c6b89 on simonre:portforwardingupdate into 95cd5f3 on gophercloud:master.

@jtopjian
Copy link
Contributor

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 16, 2019

Build failed.

jtopjian
jtopjian approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 9898047 into gophercloud:master Sep 17, 2019
@simonre simonre mentioned this pull request Sep 17, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonre @coveralls @jtopjian