Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octavia LBaaSv2: Allow setting an empty members list #1736

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Octavia LBaaSv2: Allow setting an empty members list #1736

merged 1 commit into from
Oct 11, 2019

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Oct 10, 2019

Resolves #1735

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.892% when pulling 4ca539c on kayrus:empty-members-list into 1effcf5 on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 10, 2019

Build succeeded.

@kayrus
Copy link
Contributor Author

kayrus commented Oct 10, 2019

@jtopjian ready for review

jtopjian
jtopjian approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit f3883c7 into gophercloud:master Oct 11, 2019
@kayrus kayrus deleted the empty-members-list branch October 11, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Octavia LBaaSv2: Allow setting an empty members list
3 participants
@kayrus @coveralls @jtopjian