Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json struct tags #1840

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Fix json struct tags #1840

merged 2 commits into from
Feb 7, 2020

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Feb 6, 2020

For #1839

This fixes malformed JSON struct tags in networking/v2/extensions/lbaas/vips and baremetal/v1/ports.

@coveralls
Copy link

coveralls commented Feb 6, 2020 •
edited

Coverage Status

Coverage remained the same at 77.044% when pulling 372fcf6 on alrs:fix-json-struct-tags into ca606dc on gophercloud:master.

@alrs
Copy link
Contributor Author

alrs commented Feb 6, 2020

Did a fixup to put required:"true" on Op and Path in UpdateOperation{}.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 6, 2020

Build succeeded.

jtopjian
jtopjian approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for fixing this!

@jtopjian jtopjian merged commit b52e4c3 into gophercloud:master Feb 7, 2020
@jtopjian jtopjian mentioned this pull request Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alrs @coveralls @jtopjian