Cinder V3: Update a volume’s bootable status #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayrus
force-pushed
the
volume-bootable-action
branch
from
dc7939a
to
a73b00f
Compare
|
Build succeeded.
|
|
@jtopjian ready for review |
kayrus
force-pushed
the
volume-bootable-action
branch
from
a73b00f
to
d810494
Compare
|
Build succeeded.
|
|
This looks good to me. Is there any way to implement a small/quick acceptance test to validate that the field has changed from true/false (or vice versa)? |
|
Build succeeded.
|
|
@jtopjian acceptance tests done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1890