Adding query parameter to Compute list services API

acceptance/openstack/compute/v2/services_test.go

@@ -17,7 +17,7 @@ func TestServicesList(t *testing.T) {
 	client, err := clients.NewComputeV2Client()
 	th.AssertNoErr(t, err)
 
-	allPages, err := services.List(client).AllPages()
+	allPages, err := services.List(client, nil).AllPages()
 	th.AssertNoErr(t, err)
 
 	allServices, err := services.ExtractServices(allPages)
@@ -34,3 +34,32 @@ func TestServicesList(t *testing.T) {
 
 	th.AssertEquals(t, found, true)
 }
+
+func TestServicesListWithOpts(t *testing.T) {
+	clients.RequireAdmin(t)
+
+	client, err := clients.NewComputeV2Client()
+	th.AssertNoErr(t, err)
+
+	opts := services.ListOpts{
+		Binary: "nova-scheduler",
+	}
+
+	allPages, err := services.List(client, opts).AllPages()
+	th.AssertNoErr(t, err)
+
+	allServices, err := services.ExtractServices(allPages)
+	th.AssertNoErr(t, err)
+
+	var found bool
+	for _, service := range allServices {
+		tools.PrintResource(t, service)
+		th.AssertEquals(t, service.Binary, "nova-scheduler")
+
+		if service.Binary == "nova-scheduler" {
+			found = true
+		}
+	}
+
+	th.AssertEquals(t, found, true)
+}

openstack/compute/v2/extensions/services/doc.go

@@ -4,7 +4,11 @@ cloud.
 
 Example of Retrieving list of all services
 
-	allPages, err := services.List(computeClient).AllPages()
+	opts := services.ListOpts{
+		Binary: "nova-scheduler",
+	}
+
+	allPages, err := services.List(computeClient, opts).AllPages()
 	if err != nil {
 		panic(err)
 	}

openstack/compute/v2/extensions/services/requests.go

@@ -5,9 +5,36 @@ import (
 	"github.com/gophercloud/gophercloud/pagination"
 )
 
+// ListOptsBuilder allows extensions to add additional parameters to
+// the List request.
+type ListOptsBuilder interface {
+	ToServicesListQuery() (string, error)
+}
+
+// ListOpts represents options to list services.
+type ListOpts struct {
+	Binary string `q:"binary"`
+	Host   string `q:"host"`
+}
+
+// ToServicesListQuery formats a ListOpts into a query string.
+func (opts ListOpts) ToServicesListQuery() (string, error) {
+	q, err := gophercloud.BuildQueryString(opts)
+	return q.String(), err
+}
+
 // List makes a request against the API to list services.
-func List(client *gophercloud.ServiceClient) pagination.Pager {
-	return pagination.NewPager(client, listURL(client), func(r pagination.PageResult) pagination.Page {
+func List(client *gophercloud.ServiceClient, opts ListOptsBuilder) pagination.Pager {
+	url := listURL(client)
+	if opts != nil {
+		query, err := opts.ToServicesListQuery()
+		if err != nil {
+			return pagination.Pager{Err: err}
+		}
+		url += query
+	}
+
+	return pagination.NewPager(client, url, func(r pagination.PageResult) pagination.Page {
 		return ServicePage{pagination.SinglePageBase(r)}
 	})
 }

openstack/compute/v2/extensions/services/testing/requests_test.go

@@ -15,7 +15,7 @@ func TestListServicesPre253(t *testing.T) {
 	HandleListPre253Successfully(t)
 
 	pages := 0
-	err := services.List(client.ServiceClient()).EachPage(func(page pagination.Page) (bool, error) {
+	err := services.List(client.ServiceClient(), nil).EachPage(func(page pagination.Page) (bool, error) {
 		pages++
 
 		actual, err := services.ExtractServices(page)
@@ -47,7 +47,11 @@ func TestListServices(t *testing.T) {
 	HandleListSuccessfully(t)
 
 	pages := 0
-	err := services.List(client.ServiceClient()).EachPage(func(page pagination.Page) (bool, error) {
+	opts := services.ListOpts{
+		Binary: "fake-binary",
+		Host:   "host123",
+	}
+	err := services.List(client.ServiceClient(), opts).EachPage(func(page pagination.Page) (bool, error) {
 		pages++
 
 		actual, err := services.ExtractServices(page)