make introspection.RootDiskType int64 rather than int (#1634)

[mwhudson]

Fixes tests (and functionality I suspect!) on 32-bit systems.

[coveralls]

Coverage remained the same at 79.416% when pulling fd95bfa on mwhudson:issue-1634 into 2921f45 on gophercloud:master.

[theopenlab-ci]

Build failed.

• gophercloud-unittest : SUCCESS in 6m 48s
• gophercloud-acceptance-test : TIMED_OUT in 3h 02m 01s
• gophercloud-acceptance-test-ironic : SUCCESS in 1h 37m 22s

[jtopjian]

Can this be removed? It's causing the Travis failure. I'll clean this up in another PR.

[mwhudson]

Oh yes, I meant to remove that before pushing, cleaned up now.

[jtopjian]

@mwhudson Thank you for looking into this - it's really appreciated.

From your comments in #1634:

I don't know if it would be too much of an abi break, but

Breaking changes are OK as long as they are justified.

github.com/gophercloud/gophercloud/openstack/baremetalintrospection/v1/introspection.RootDiskType being an "int" vs an "int64" definitely seems like a mistake.

Yes, from the error message given in #1634, I agree. I'd also be inclined to change other int's to int64 in this package while we're at it.

[mwhudson]

@mwhudson Thank you for looking into this - it's really appreciated.

No worries, thanks for the quick review!

From your comments in #1634:

I don't know if it would be too much of an abi break, but

Breaking changes are OK as long as they are justified.

Fair enough.

github.com/gophercloud/gophercloud/openstack/baremetalintrospection/v1/introspection.RootDiskType being an "int" vs an "int64" definitely seems like a mistake.

Yes, from the error message given in #1634, I agree. I'd also be inclined to change other int's to int64 in this package while we're at it.

All of them? I can do that easily enough, of course. I did have a quick scan and didn't think any of the others would be problematic but it might be best to be consistent.

[jtopjian]

All of them? I can do that easily enough, of course. I did have a quick scan and didn't think any of the others would be problematic but it might be best to be consistent.

Sorry - I may have been too broad in my last message 🙂

I should have said that we should look at changing them where it makes sense, and only in this introspection package. For example, the Memory fields might work better as an int64. I know it's a long shot to have that much memory, but who knows 2-3 years from now. Things like that.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 5m 50s
• gophercloud-acceptance-test : SUCCESS in 1h 02m 08s
• gophercloud-acceptance-test-ironic : SUCCESS in 1h 20m 29s

[mwhudson]

Well OK. Want to merge this, or fix it yourself how ever you like? :)

[jtopjian]

LGTM - thank you!