Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block volume extension for os-vol-host-attr #2212

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add block volume extension for os-vol-host-attr #2212

merged 1 commit into from
Sep 14, 2021

Conversation

kristian-lesko
Copy link
Contributor

@kristian-lesko kristian-lesko commented Sep 10, 2021

The os-vol-host-attr is returned by OpenStack API;
let's add an extension to allow using this value.

Fixes #2211.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 10, 2021

Build succeeded.

@jtopjian
Copy link
Contributor

@kristian-lesko Thank you for submitting this.

This might seem overkill for a single field, but technically os-vol-host-attr:host is an API extension as defined here: https://github.com/openstack/cinder/blob/393c2e4ad90c05ebf28cc3a2c65811d7e1e0bc18/cinder/api/contrib/volume_host_attribute.py

Instead of adding this field to the main Volume struct, create a dedicated package for it like this one: https://github.com/gophercloud/gophercloud/tree/513734676e6495f6fec60e7aaf1f86f1ce807428/openstack/blockstorage/extensions/volumetenants

Please let me know if you have any questions.

The os-vol-host-attr is returned by OpenStack API;
let's add an extension to allow using this value.
@kristian-lesko kristian-lesko changed the title Add support for os-vol-host-attr in block volumes Add block volume extension for os-vol-host-attr Sep 14, 2021
@kristian-lesko
Copy link
Contributor Author

Thanks for your comment @jtopjian; PR updated per your suggestion.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 14, 2021

Build succeeded.

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you very much!

@jtopjian jtopjian merged commit bdb54d4 into gophercloud:master Sep 14, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.821% when pulling 13c3d46 on kristian-lesko:os-vol-host-attr into 3b820fa on gophercloud:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value for os-vol-host-attr:host not returned for block volumes
3 participants