Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new workflow for greetings #2266

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add new workflow for greetings #2266

merged 1 commit into from
Feb 15, 2022

Conversation

EmilienM
Copy link
Contributor

Add a new workflow to be welcome our new contributors and let them know how to find help.

@coveralls
Copy link

coveralls commented Nov 10, 2021

Coverage Status

Coverage remained the same at 79.903% when pulling 0fbcbfe on greetings into 408025a on master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2021

Build failed.

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm all for improving the new contributor onboarding experience. I think it's important for them to know what to expect when making their first contribution to a project.

Please let the maintainers know if your issue has not got enough attention after a few days.
If any doubt, please consult our issue [tutorial](https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-02-issues.md).
pr-message: |
Thank you for reporting your first PR! Be sure that we will be looking at it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thank you for reporting your first PR! Be sure that we will be looking at it.
Thank you for submitting your first PR! Be sure that we will be looking at it.

repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: |
Thank you for reporting your first issue! Be sure that we will be looking at it.
Please let the maintainers know if your issue has not got enough attention after a few days.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the message should be to thank the user for their contribution and explain the process so they know what to expect. In particular, we should let them know it's totally normal if they don't get an answer right away.

If we want to invite new contributors to reach out to maintainers directly (not sure we should) we'll have to explain how they're supposed to do it.

@pierreprinetti
Copy link
Contributor

Very good idea, @EmilienM. I'm all for this!

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 14, 2022

Build succeeded.

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, otherwise LGTM.

.github/workflows/greetings.yml Outdated Show resolved Hide resolved
.github/workflows/greetings.yml Outdated Show resolved Hide resolved
Add a new workflow to be welcome our new contributors and let them know how to find help.
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 15, 2022

Build succeeded.

@mandre mandre merged commit 775425c into master Feb 15, 2022
@mandre mandre deleted the greetings branch February 15, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants