-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new workflow for greetings #2266
Conversation
Build failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm all for improving the new contributor onboarding experience. I think it's important for them to know what to expect when making their first contribution to a project.
.github/workflows/greetings.yml
Outdated
Please let the maintainers know if your issue has not got enough attention after a few days. | ||
If any doubt, please consult our issue [tutorial](https://github.com/gophercloud/gophercloud/blob/master/docs/contributor-tutorial/step-02-issues.md). | ||
pr-message: | | ||
Thank you for reporting your first PR! Be sure that we will be looking at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reporting your first PR! Be sure that we will be looking at it. | |
Thank you for submitting your first PR! Be sure that we will be looking at it. |
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
issue-message: | | ||
Thank you for reporting your first issue! Be sure that we will be looking at it. | ||
Please let the maintainers know if your issue has not got enough attention after a few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the message should be to thank the user for their contribution and explain the process so they know what to expect. In particular, we should let them know it's totally normal if they don't get an answer right away.
If we want to invite new contributors to reach out to maintainers directly (not sure we should) we'll have to explain how they're supposed to do it.
Very good idea, @EmilienM. I'm all for this! |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit, otherwise LGTM.
Add a new workflow to be welcome our new contributors and let them know how to find help.
Build succeeded.
|
Add a new workflow to be welcome our new contributors and let them know how to find help.