Bump Go to 1.14 #2294
Merged
Bump Go to 1.14 #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run against Go tip and against the oldest supported version.
pierreprinetti
force-pushed
the
goversions
branch
from
05b94e9
to
3ca7762
Compare
|
LGTM |
|
@EmilienM Please note that I have now bumped Go to v1.14 in go.mod |
Running retests in a separate action to increase explicitness and to parallelise WRT to the other unit tests.
The `testhelper` package uses `http.Header`'s method `Values`, which [was introduced in GO 1.14][1]. [1]: https://pkg.go.dev/net/http#Header.Values
pierreprinetti
force-pushed
the
goversions
branch
2 times, most recently
from
901bf34
to
b3d2520
Compare
The syntax for build hints has slightly changed and gofmt complains.
pierreprinetti
force-pushed
the
goversions
branch
from
b3d2520
to
cfaf0b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several little changes to the test definitions:
crypto/sshAdditionally, it turns out that we are using in
testhelpera method that was introduced in Go 1.14. With this PR, I propose to bump the minimum acceptable version of Go to v1.14 ingo.mod.