Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-v2] Replace baremetal job with Github Action #2308

Merged
merged 1 commit into from Jan 14, 2022
Merged

[CI-v2] Replace baremetal job with Github Action #2308

merged 1 commit into from Jan 14, 2022

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Jan 6, 2022

This runs a Github Action to:

  • Deploy Devstack with Ironic
  • Run acceptance/openstack/baremetal
  • Post logs if we encounter a failure
  • Replace the previous CI job managed in Zuul

@EmilienM
Copy link
Contributor Author

EmilienM commented Jan 6, 2022

@iurygregory FYI

@coveralls
Copy link

coveralls commented Jan 6, 2022

Coverage Status

Coverage remained the same at 79.92% when pulling 87d87f4 on EmilienM:civ2_baremetal into 1e844ba on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 6, 2022

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 7, 2022

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 12, 2022

Build failed.

.github/workflows/functional-baremetal.yaml Outdated Show resolved Hide resolved
run: ./script/acceptancetest
env:
DEVSTACK_PATH: ${{ github.workspace }}/devstack
ACCEPTANCE_TESTS_FILTER: '^.*baremetal/v1.*$'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other acceptance tests for BM. Are you intentionally skipping them?

Note that the noauth tests probably won't work against the deployed devstack, you may want to update the regex to skip them, see 6bb1125

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandre FYI this didn't change anything:

=== RUN   TestPortsUpdate
    conditions.go:81: this test requires Ironic using http_basic, set OS_USERNAME, OS_PASSWORD and IRONIC_ENDPOINT
--- SKIP: TestPortsUpdate (0.00s)
PASS
ok  	github.com/gophercloud/gophercloud/acceptance/openstack/baremetal/httpbasic	0.004s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we move on from now and we'll revisit later to enable these tests by setting the env vars.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you then need to use grep with the perl regex for the negative lookahead to work, see 6bb1125#diff-bcc2d3c788591acc07e26f74aa38c998fb12c07f2ad1bdd9ecaeea46a8705f9dR24

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2022

Build failed.

This runs a Github Action to:

* Deploy Devstack with Ironic
* Add a function to skip tests below a certain OpenStack release
* Skip TestNodesRAIDConfig below Ussuri, it's not working anyway.
* Run acceptance/openstack/baremetal
* Post logs if we encounter a failure
* Replace the previous CI job managed in Zuul
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 14, 2022

Build failed.

@mandre mandre merged commit 9b846f5 into gophercloud:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants