-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerinfra: add a few missing labels fields #2377
Conversation
Build failed.
|
Thanks for the PR. You should normally have received a nice welcoming message for your first PR but our automation failed. I'm copying the content below:
I'll review your PR in a minute. |
This LGTM, however we don't have CI exercising your changes against a real openstack. We have yet to port the Magnum CI to github actions - I'd like we do that before merging your PR. |
Hey @MrFreezeex, we've recently merged the change to enable CI for Magnum in #2379. Could you rebase this PR on top of master so that we see your change in action before we merge it? |
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
2ae729c
to
cc57cde
Compare
Thanks for the great work, I just did that :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh, this was pointless - we're still not exercising this new code in the acceptance tests. I couldn't get Magnum to deploy a cluster in CI and had to skip the tests that would have exercised this code :-/
Sorry for all the trouble, let's merge your PR as it looks good and the risk it breaks anything is rather low.
Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.
Fixes #2376
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/magnum/blob/20413d0c45dc7a6426072bd889bfb71c73fa62b1/magnum/api/controllers/v1/nodegroup.py#L129-L145
https://github.com/openstack/magnum/blob/20413d0c45dc7a6426072bd889bfb71c73fa62b1/magnum/api/controllers/v1/cluster.py#L187-L203