Fix BareMetalV1 version #2486
Merged
Fix BareMetalV1 version #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openstack/client.go
Outdated
| @@ -363,7 +363,11 @@ func initClientOpts(client *gophercloud.ProviderClient, eo gophercloud.EndpointO | |||
| // NewBareMetalV1 creates a ServiceClient that may be used with the v1 | |||
| // bare metal package. | |||
| func NewBareMetalV1(client *gophercloud.ProviderClient, eo gophercloud.EndpointOpts) (*gophercloud.ServiceClient, error) { | |||
| return initClientOpts(client, eo, "baremetal") | |||
| sc, err := initClientOpts(client, eo, "baremetal") | |||
| if !strings.HasSuffix(sc.Endpoint, "v1/") { | |||
There was a problem hiding this comment.
Is it possible that we have suffix v1 without the /?
There was a problem hiding this comment.
yes you are right maybe we nee double check v1/ and v1 ?
There was a problem hiding this comment.
Maybe it is best to check both ?
if !strings.HasSuffix(strings.TrimSuffix(sc.Endpoint, "/"), "v1")
There was a problem hiding this comment.
Looking at the initialization for the other clients, it seems unlikely the suffix has v1 without the /, but better be safe than sorry.
snigle
force-pushed
the
v1.0.0-ovh-baremetal-fix
branch
from
535d100
to
a934f01
Compare
EmilienM
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2485
There is no documentation to link as it's only a configuration on keystone.