loadbalancer: Use CreateMemberOpts instead of BatchUpdateMemberOpts in PoolCreateOpts #2560
Conversation
…n PoolCreateOpts In order to support members without any subnet, the struct for the pool members need to be CreateMemberOpts.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
|
cc @dulek |
|
Could you please update the tests accordingly, so at least we get happy CI jobs. Thanks |
|
also FYI I marked this PR as non backward compatible since we're changing the type of an existing parameter in a struct. |
|
I'm not sure about the CI, but the change makes sense to me. |
|
Wait, are we allowed to break API like this? With this change |
previously this happened a lot, see #1332 |
|
Alright, cool, then works for me. |
|
@dulek @kayrus @mandre |
My bad. For my defense, I'll blame Github's terrible UI. |
In order to support members without any subnet, the struct for the pool members need to be CreateMemberOpts.
Fixes #2559
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API validation for UUID in octavia:
https://opendev.org/openstack/octavia/src/commit/c2c59f4c9eb9f9ef6081e386bf2bc1badc145241/octavia/api/v2/types/member.py#L127