Trove: Add ability to create instance replicas via replica_of parameter #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
kayrus
reviewed
Jul 18, 2023
| @@ -55,6 +55,8 @@ type CreateOpts struct { | |||
| Size int | |||
| // Specifies the volume type. | |||
| VolumeType string | |||
| // ID or name of an existing instance to replicate from. Optional. | |||
| ReplicaOf string | |||
There was a problem hiding this comment.
I wonder why CreateOpts didn't have the JSON tags in the first place.
|
closing in favor of #2877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2697
Openstack API Ref:
https://docs.openstack.org/api-ref/database/?expanded=create-database-instance-detail#create-database-instance
Merging this PR and #2483 should allow me to create a PR to terraform openstack provider adding availability zone and replication support