Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadbalancer additional_vips #2699 #2700

Closed
wants to merge 3 commits into from
Closed

loadbalancer additional_vips #2699 #2700

wants to merge 3 commits into from

Conversation

snigle
Copy link
Contributor

@snigle snigle commented Jul 19, 2023

@coveralls
Copy link

coveralls commented Jul 19, 2023 •
edited

Coverage Status

coverage: 79.099%. remained the same when pulling 966fd27 on ovh:v1.5.0-ovh-loadbalancer into 18eebcb on gophercloud:master.

EmilienM
EmilienM requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add testing coverage in acceptance. Thanks!

@snigle
Copy link
Contributor Author

snigle commented Jul 19, 2023

Please also add testing coverage in acceptance. Thanks!

tried to write them but I don't have environment to execute it

@snigle snigle requested a review from EmilienM July 25, 2023 10:20
@snigle
Copy link
Contributor Author

snigle commented Aug 25, 2023

tested on my production environment and works. I don't understand why acceptances fails in github

@EmilienM
Copy link
Contributor

CI seems unhappy now with

ERROR octavia.network.drivers.neutron.allowed_address_pairs [None req-e3045032-a87e-405a-9ebd-22444b123442 admin admin] Error creating neutron port on network fe1b4794-ce05-4b25-9fa9-7aa5f3ca23b7 due to ConflictException('ConflictException: 409').: openstack.exceptions.ConflictException: ConflictException: 409: Client Error for url: http://10.1.0.39:9696/networking/v2.0/ports, IP address 192.168.2.127 already allocated in subnet 80595bf8-fe08-485f-a1b3-1f03ea35e965

@EmilienM
Copy link
Contributor

Could you please rebase, so it'll trigger CI again and if green I'll merge it.

@oblazek oblazek mentioned this pull request Jan 12, 2024
Closed
@oblazek
Copy link

oblazek commented Jan 12, 2024

@snigle any chance you can finish it up?

@mdbooth
Copy link
Contributor

mdbooth commented Jan 15, 2024

@dulek Any thoughts on this?

@dulek
Copy link
Contributor

dulek commented Jan 15, 2024

It looks good to me from the functional standpoint.

@EmilienM
Copy link
Contributor

please rebase, it'll trigger proper CI jobs. Thanks !

@EmilienM EmilienM mentioned this pull request Jan 16, 2024
Merged
@EmilienM EmilienM closed this Jan 16, 2024
@EmilienM
Copy link
Contributor

taken care here: #2866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing additional vips in octavia loadbalancer sdk
6 participants
@snigle @coveralls @EmilienM @oblazek @mdbooth @dulek