Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.7.0 #2789

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Prepare 1.7.0 #2789

merged 1 commit into from
Sep 25, 2023

Conversation

EmilienM
Copy link
Contributor

Update CHANGELOG and update the user agent.

@github-actions github-actions bot added the semver:major Breaking change label Sep 22, 2023
@coveralls
Copy link

Coverage Status

coverage: 77.421%. remained the same when pulling 4f4a056 on EmilienM:release_1.7.0 into d462f04 on gophercloud:v1.

@pierreprinetti
Copy link
Contributor

I wanted to paste a list of the incompatible changes listed by go-apidiff, so that we could check that all changes are in tests.

However, I found out that go-apidiff actually errored: https://github.com/gophercloud/gophercloud/actions/runs/6278222927/job/17051513912?pr=2789

@mandre
Copy link
Contributor

mandre commented Sep 24, 2023

I wanted to paste a list of the incompatible changes listed by go-apidiff, so that we could check that all changes are in tests.

However, I found out that go-apidiff actually errored: https://github.com/gophercloud/gophercloud/actions/runs/6278222927/job/17051513912?pr=2789

You actually have to look at the very end to see why it categorizes it as breaking change:

github.com/gophercloud/gophercloud
  Incompatible changes:
  - DefaultUserAgent: value changed from "gophercloud/v1.6.0" to "gophercloud/v1.7.0"'

Regarding the go-apidiff failure with the cache, I believe it would be fixed with joelanford/go-apidiff@0511785 and we're just waiting for a new version.

@EmilienM
Copy link
Contributor Author

Yeah I think this version is backward compatible. Let me know otherwise.

@EmilienM EmilienM merged commit 1ef3b08 into gophercloud:v1 Sep 25, 2023
16 of 19 checks passed
@EmilienM EmilienM deleted the release_1.7.0 branch September 25, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants