Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for CDN (poppy) #2809

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Remove code for CDN (poppy) #2809

merged 1 commit into from
Oct 13, 2023

Conversation

EmilienM
Copy link
Contributor

OpenStack CDN (Poppy) isn't maintained anymore, last commit was 5 years ago:
https://opendev.org/x/poppy/commits/branch/master

This patch removes all the code that called CDN v1 API, which is not tested, and the upstream project doesn't seem to be alive anymore.

This effort is made for helping to maintain Gophercloud and clean the things we don't need/use anymore.

OpenStack CDN (Poppy) isn't maintained anymore, last commit was 5 years
ago:
https://opendev.org/x/poppy/commits/branch/master

This patch removes all the code that called CDN v1 API, which is not
tested, and the upstream project doesn't seem to be alive anymore.

This effort is made for helping to maintain Gophercloud and clean the
things we don't need/use anymore.
@EmilienM
Copy link
Contributor Author

This was approved here by original maintainers: #2296

@github-actions github-actions bot added the semver:major Breaking change label Oct 12, 2023
@coveralls
Copy link

Coverage Status

coverage: 77.445% (+0.004%) from 77.441% when pulling 4dc5596 on cdn_removal into d00e5c5 on master.

@EmilienM EmilienM merged commit fed1858 into master Oct 13, 2023
27 checks passed
@EmilienM EmilienM deleted the cdn_removal branch October 13, 2023 18:18
mandre added a commit to shiftstack/gophercloud that referenced this pull request Mar 22, 2024
The PR removing the code for CDN [1] merged around the same time the
fixtures were modified to no longer be part of the public API [2],
causing these files to stay in the tree.

This commit cleans up files that shouldn't be here.

[1] gophercloud#2809
[2] gophercloud#2811
@mandre mandre mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants