Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octavia: Add tags to resources missing them #2828

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Oct 30, 2023

Seems like a bunch of resources are missing the tags fiels that Octavia API reference specified. This commit adds them.

Fixes #2829

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/load-balancer/v2/index.html

Seems like a bunch of resources are missing the tags fiels that Octavia
API reference specified. This commit adds them.
@github-actions github-actions bot added the semver:major Breaking change label Oct 30, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@coveralls
Copy link

Coverage Status

coverage: 77.962%. remained the same when pulling af41ccd on dulek:octavia-monitor-tags into cc89262 on gophercloud:master.

@EmilienM EmilienM merged commit 6a4ce75 into gophercloud:master Oct 30, 2023
28 checks passed
@EmilienM
Copy link
Contributor

congrats on your first PR 😆

@dulek
Copy link
Contributor Author

dulek commented Oct 31, 2023

@EmilienM: Can you label it for v1 inclusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tags on Octavia resources
3 participants