Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare the v1.8.0 release #2839

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Prepare the v1.8.0 release #2839

merged 1 commit into from
Nov 30, 2023

Conversation

pierreprinetti
Copy link
Contributor

No description provided.

@pierreprinetti pierreprinetti requested a review from a team November 30, 2023 09:10
@github-actions github-actions bot added the semver:major Breaking change label Nov 30, 2023
@coveralls
Copy link

coveralls commented Nov 30, 2023 •
edited

Coverage Status

coverage: 77.883%. remained the same
when pulling 796aba1 on shiftstack:prepare_v1.8.0
into f8d6f33 on gophercloud:v1.

@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@pierreprinetti pierreprinetti marked this pull request as draft November 30, 2023 10:13
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@pierreprinetti
Copy link
Contributor Author

Depends on #2840

@pierreprinetti pierreprinetti marked this pull request as ready for review November 30, 2023 13:30
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Nov 30, 2023
@pierreprinetti pierreprinetti added semver:minor Backwards-compatible change and removed semver:major Breaking change labels Nov 30, 2023
mandre
mandre approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierreprinetti pierreprinetti merged commit 05b77af into gophercloud:v1 Nov 30, 2023
20 checks passed
@pierreprinetti pierreprinetti deleted the prepare_v1.8.0 branch November 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

Assignees
No one assigned
Labels
semver:minor Backwards-compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierreprinetti @coveralls @mandre