[db/v1/instance]: adding support for availability_zone for a db instance

[zhekazuev]

Issue

For #2874

Description

• code: added AvailabilityZone struct field
• code: add empty checking for that field
• tests: add availability_zone to testing/fixtures_test.go
• tests: add AvailabilityZone to testing/requests_test.go

Links

• API Docs: https://docs.openstack.org/api-ref/database/#create-database-instance
• Model - Create: https://github.com/openstack/trove/blob/422507ca425f5a1be10cfc979165e7b8d58dfffa/trove/instance/models.py#L1186
• Service - Create: https://github.com/openstack/trove/blob/422507ca425f5a1be10cfc979165e7b8d58dfffa/trove/instance/service.py#L360

Related:

• DB V1: Error creating openstack_db_instance_v1: there is no availability_zone field in provider terraform-provider-openstack/terraform-provider-openstack#1644
• [db/v1/instance]: add availability_zone field terraform-provider-openstack/terraform-provider-openstack#1643
• trove: Add Grant and Revoke database access feature #2831
• Add support for availability zone in DBaaS  #2483

[github-actions]

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

[zhekazuev]

@EmilienM Hi,

Could you review it?

[zhekazuev]

Tests result:

@zhekazuev ➜ .../openstack/db/v1/instances (feature/add-openstack-db-instance-az) $ go test -tags fixtures ./...
?       github.com/gophercloud/gophercloud/openstack/db/v1/instances    [no test files]
ok      github.com/gophercloud/gophercloud/openstack/db/v1/instances/testing    (cached)

[EmilienM]

ideal you would squash commits here

[zhekazuev]

Squashing well done.

[EmilienM]

Thanks for your first contribution and welcome here!

[coveralls]

coverage: 77.835% (+0.003%) from 77.832%
when pulling 74052e2 on zhekazuev:feature/add-openstack-db-instance-az
into d0c1d7e on gophercloud:master.

[zhekazuev]

@EmilienM Short question about releasing,

That changes needs for different project, terraform-provider-openstack, so is it possible to release new version of that sdk?
E.g. 1.8.1?

Or how can I reuse that package by commit?
When I tried to do go get ...@<commit> I recieved 1.5.1-... version, expected 1.8.0-....

[EmilienM]

If you want this patch in v1, you need to add the laberl backport-v1 label in this PR and the backport PR will be automatically created and reviewed by us.
If you don't want v1, you'll need to wait for a v2 (@pierreprinetti is leading this effort at the moment, I'm unsure about its exact status).

[zhekazuev]

If you want this patch in v1, you need to add the laberl backport-v1 label in this PR and the backport PR will be automatically created and reviewed by us.

@EmilienM,
I cannot add label backport-v1 to the PR, maybe to low permissions level.
Could you do that?