Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing QoS field for router #2881

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

al26p
Copy link
Contributor

@al26p al26p commented Jan 25, 2024

Fixes #2880

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/neutron/blob/master/neutron/objects/router.py#L376

@github-actions github-actions bot added the semver:minor Backwards-compatible change label Jan 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Jan 25, 2024
@coveralls
Copy link

Coverage Status

coverage: 77.904%. remained the same
when pulling f7533c9 on al26p:master
into b7f2d15 on gophercloud:master.

Copy link
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v1 This PR will be backported to v1 semver:minor Backwards-compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for qos_policy_id onexternal gateway
3 participants