Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authentication: Add WithContext functions #2890

Merged
merged 2 commits into from
Feb 5, 2024
Merged

authentication: Add WithContext functions #2890

merged 2 commits into from
Feb 5, 2024

Conversation

pierreprinetti
Copy link
Contributor

@pierreprinetti pierreprinetti commented Feb 2, 2024 •
edited

Allow using a context to cancel and trace authentication calls.

In the process, add WithContext functions to token-requesting packages:

  • openstack/identity/v2/tokens/requests.go
  • openstack/identity/v3/extensions/ec2tokens/requests.go
  • openstack/identity/v3/extensions/oauth1/requests.go
  • openstack/identity/v3/tokens/requests.go

@github-actions github-actions bot added the semver:minor Backwards-compatible change label Feb 2, 2024
@coveralls
Copy link

coveralls commented Feb 2, 2024 •
edited

Coverage Status

coverage: 77.874% (+0.01%) from 77.863%
when pulling c9b54ab on shiftstack:tokens_withcontext
into 901515a on gophercloud:master.

@github-actions github-actions bot removed the semver:minor Backwards-compatible change label Feb 2, 2024
@pierreprinetti pierreprinetti changed the title tokens: Add WithContext functions authentication: Add WithContext functions Feb 2, 2024
@github-actions github-actions bot added the semver:minor Backwards-compatible change label Feb 2, 2024
@pierreprinetti
client: Add WithContext functions
c9b54ab 
Allow using a context to cancel and trace authentication calls.
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Feb 2, 2024
@pierreprinetti pierreprinetti added the backport-v1 This PR will be backported to v1 label Feb 2, 2024
@pierreprinetti pierreprinetti mentioned this pull request Feb 5, 2024
Merged
@EmilienM EmilienM merged commit 09daf4a into gophercloud:master Feb 5, 2024
29 checks passed
@EmilienM EmilienM deleted the tokens_withcontext branch February 5, 2024 13:15
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM EmilienM approved these changes

Assignees
No one assigned
Labels
backport-v1 This PR will be backported to v1 semver:minor Backwards-compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierreprinetti @coveralls @EmilienM