v2: Add ParseOption type to made clouds.Parse() more usable for optional With* funcs #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That fix following error returned by Parse(): ``` Failed to parse clouds.yaml: yaml: input error: read /etc/openstack: is a directory ``` Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
Fix gophercloud#2913 Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
vooon
changed the title
|
I understand that it can be useful to conditionally add functional options, and indeed I can't find a straightforward way of allowing that without exposing the options type. Thank you @vooon for your contribution. |
|
@pierreprinetti that's quite common way doing With*, for example grpc.DialOption |
pierreprinetti
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that makes easier to have conditional With like that:
https://github.com/sardinasystems/fleeting-plugin-openstack/blob/90c744fc9ee23d8a18dad96f2a677a9d1a54222c/provider.go#L44-L52
Fixes #2913
In addition it fixes search for default
/etc/openstack/clouds.yamlfile.