Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change coding style #2928

Merged
merged 2 commits into from
Feb 16, 2024
Merged

change coding style #2928

merged 2 commits into from
Feb 16, 2024

Conversation

yj-yoo
Copy link
Contributor

@yj-yoo yj-yoo commented Feb 16, 2024

I changed the coding style to be a little more golang-like.

@yj-yoo
chage coding style
09ac067 
Signed-off-by: Youngjun <yj.yoo@okestro.com>
@github-actions github-actions bot added the semver:patch No API change label Feb 16, 2024
@pierreprinetti
Copy link
Contributor

Looks legit! Thank you.
Just run go fmt ./... to please the linter.

@yj-yoo
apply go fmt for lint
66a938b 
Signed-off-by: Youngjun <yj.yoo@okestro.com>
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels Feb 16, 2024
@coveralls
Copy link

Coverage Status

coverage: 77.245% (+0.01%) from 77.233%
when pulling 66a938b on yj-yoo:change_coding_style
into d155e56 on gophercloud:master.

@yj-yoo
Copy link
Contributor Author

yj-yoo commented Feb 16, 2024

@pierreprinetti
okay. I missed it but fixed it.☺️

pierreprinetti
pierreprinetti approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and another one down the books!

@pierreprinetti pierreprinetti merged commit 45a68c2 into gophercloud:master Feb 16, 2024
19 checks passed
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti approved these changes

Assignees
No one assigned
Labels
semver:patch No API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yj-yoo @pierreprinetti @coveralls