Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove golang patch version from main go.mod #3032

Merged
merged 1 commit into from Apr 16, 2024

Conversation

tuminoid
Copy link
Contributor

Since golang 1.21, the patch version in go.mod is trickled to downstream consumers as minimum go version, and to their consumers etc. Remove the patch version, and use only minor version to allow consumers some flexibility.

Fixes: #3031

Since golang 1.21, the patch version in go.mod is trickled to
downstream consumers as minimum go version, and to their consumers etc.
Remove the patch version, and use only minor version to allow
consumers some flexibility.

Fixes: gophercloud#3031

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@github-actions github-actions bot added the semver:patch No API change label Apr 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@pierreprinetti pierreprinetti self-assigned this Apr 16, 2024
@coveralls
Copy link

Coverage Status

coverage: 78.32%. remained the same
when pulling a4b0b28 on Nordix:tuomo/fix-go-mod
into 280727e on gophercloud:master.

Copy link
Contributor

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierreprinetti pierreprinetti merged commit 9aef383 into gophercloud:master Apr 16, 2024
13 checks passed
@tuminoid tuminoid deleted the tuomo/fix-go-mod branch April 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch No API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang 1.21.6 is forced on downstream consumers of gophercloud/v2
3 participants