Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clouds: Fix secure.yaml parsing #3041

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

pierreprinetti
Copy link
Contributor

@pierreprinetti pierreprinetti commented May 6, 2024

Before this patch, no secure.yaml could ever be found by the Parse function, because a programming error caused Gophercloud to always look at a path that doesn't exist.

Fixes #3039

@pierreprinetti pierreprinetti self-assigned this May 6, 2024
@github-actions github-actions bot added the semver:patch No API change label May 6, 2024
Before this patch, no `secure.yaml` could ever be found by the Parse
function, because a programming error caused Gophercloud to always look
at a path that doesn't exist.
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 6, 2024
@coveralls
Copy link

coveralls commented May 6, 2024

Coverage Status

coverage: 78.934% (+0.2%) from 78.706%
when pulling 181727e on shiftstack:secure_yaml
into 8b1eebe on gophercloud:master.

@pierreprinetti pierreprinetti added semver:major Breaking change semver:patch No API change and removed semver:patch No API change semver:major Breaking change labels May 6, 2024
Copy link
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the test case.

@EmilienM EmilienM merged commit f7893b8 into gophercloud:master May 6, 2024
14 of 15 checks passed
@EmilienM EmilienM deleted the secure_yaml branch May 6, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch No API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clouds.Parse() fails to parse secure.yaml
3 participants