Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test for create, get and delete aggregate #745

Merged
merged 3 commits into from
Feb 2, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions acceptance/openstack/compute/v2/aggregates_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,23 @@ func TestAggregatesList(t *testing.T) {
tools.PrintResource(t, h)
}
}

func TestAggregatesCreateGetDelete(t *testing.T) {
client, err := clients.NewComputeV2Client()
if err != nil {
t.Fatalf("Unable to create a compute client: %v", err)
}

createdAggregate, err := CreateAggregate(t, client)
if err != nil {
t.Fatalf("Unable to create an aggregate: %v", err)
}
defer DeleteAggregate(t, client, createdAggregate)

aggregate, err := aggregates.Get(client, createdAggregate.ID).Extract()
if err != nil {
t.Fatalf("Unable to get an aggregate: %v", err)
}

tools.PrintResource(t, aggregate)
}
32 changes: 32 additions & 0 deletions acceptance/openstack/compute/v2/compute.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/gophercloud/gophercloud/openstack/compute/v2/flavors"
"github.com/gophercloud/gophercloud/openstack/compute/v2/servers"

"github.com/gophercloud/gophercloud/openstack/compute/v2/extensions/aggregates"
"golang.org/x/crypto/ssh"
)

Expand Down Expand Up @@ -570,6 +571,37 @@ func CreateVolumeAttachment(t *testing.T, client *gophercloud.ServiceClient, blo
return volumeAttachment, nil
}

// CreateAggregate will create an aggregate with random name and available zone.
// An error will be returned if the aggregate could not be created.
func CreateAggregate(t *testing.T, client *gophercloud.ServiceClient) (*aggregates.Aggregate, error) {
aggregateName := tools.RandomString("aggregate_", 5)
availableZone := tools.RandomString("zone_", 5)
t.Logf("Attempting to create aggregate %s", aggregateName)

createOpts := aggregates.CreateOpts{Name: aggregateName, AvailabilityZone: availableZone}

aggregate, err := aggregates.Create(client, createOpts).Extract()
if err != nil {
return nil, err
}

t.Logf("Successfully created aggregate %d", aggregate.ID)

return aggregate, nil
}

// DeleteAggregate will delete a given host aggregate. A fatal error will occur if
// the aggregate deleting is failed. This works best when using it as a
// deferred function.
func DeleteAggregate(t *testing.T, client *gophercloud.ServiceClient, aggregate *aggregates.Aggregate) {
err := aggregates.Delete(client, aggregate.ID).ExtractErr()
if err != nil {
t.Fatalf("Unable to delete aggregate %d", aggregate.ID)
}

t.Logf("Deleted aggregate: %d", aggregate.ID)
}

// DeleteDefaultRule deletes a default security group rule.
// A fatal error will occur if the rule failed to delete. This works best when
// using it as a deferred function.
Expand Down