Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networking v2: Create Floating IP with Subnet #753

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Networking v2: Create Floating IP with Subnet #753

merged 1 commit into from
Feb 5, 2018

Conversation

jtopjian
Copy link
Contributor

@jtopjian jtopjian commented Feb 4, 2018

For #752

@jtopjian
Networking v2: Create Floating IP with Subnet
debc1ad 
This commit enables the creation of floating IPs by specifying
a subnet ID. This is useful when a floating IP pool has multiple
subnets.
@coveralls
Copy link

coveralls commented Feb 4, 2018 •
edited

Coverage Status

Coverage remained the same at 73.332% when pulling debc1ad on jtopjian:networkingv2-floatingip-subnet into fe85f95 on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 4, 2018

Build succeeded.

@jtopjian
Copy link
Contributor Author

jtopjian commented Feb 4, 2018

@dklyle @jrperritt ping for review

@jrperritt jrperritt merged commit 20b1624 into gophercloud:master Feb 5, 2018
@jrperritt jrperritt mentioned this pull request Feb 5, 2018
Closed
dklyle
dklyle reviewed Feb 6, 2018
View reviewed changes
Copy link
Contributor

@dklyle dklyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this merged already, but this LGTM too. Fills in a gap in functionality, very nice to have.

@jtopjian
Copy link
Contributor Author

jtopjian commented Feb 6, 2018

Thank you both for the quick review :)

@jtopjian jtopjian deleted the networkingv2-floatingip-subnet branch April 24, 2018 03:16
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
@jtopjian
vendor: Updating Terraform core to v0.12-rc1 (gophercloud#753)
b1406b8 
go get github.com/hashicorp/terraform@v0.12.0-rc1
go mod tidy
go mod vendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklyle dklyle dklyle left review comments

@jrperritt jrperritt jrperritt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtopjian @coveralls @jrperritt @dklyle