Vpnaas: Delete service

[simonre]

For #723

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L512

API:
https://developer.openstack.org/api-ref/network/v2/#remove-vpn-service

[coveralls]

Coverage increased (+0.03%) to 73.393% when pulling 7d2ef14 on simonre:vpnaas-service-delete into cf2bbaa on gophercloud:master.

[coveralls]

Coverage increased (+0.03%) to 73.421% when pulling 56ef594 on simonre:vpnaas-service-delete into 1858d1f on gophercloud:master.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 26s
• gophercloud-acceptance-test : SUCCESS in 39m 56s

[jtopjian]

@simonre This will need to be rebased with master when you have a moment. I did a quick glance and it looks fine, but I'll review it again once it's ready to go.

Thanks again for working on this series.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 36s
• gophercloud-acceptance-test : SUCCESS in 33m 25s

[simonre]

@jtopjian I think this is ready. I'm not too familiar with rebasing so please tell me if I did something wrong.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 46s
• gophercloud-acceptance-test : SUCCESS in 38m 49s

[jtopjian]

@simonre

I'm not too familiar with rebasing so please tell me if I did something wrong.

Ah, no problem.

The first thing to try would be this:

$ git checkout master
$ git pull
$ git checkout vpnaas-service-delete
$ git rebase -i master

You'll then be prompted with a list of commits. You want to make sure that only the commits for this PR are chosen and remove any other commits from other PRs / merges.

If you want to practice, doing this should work:

$ git checkout master
$ git pull
$ git checkout vpnaas-service-delete
$ git checkout -b vpnaas-service-delete-rebase-practice
$ git rebase -i master

If you feel you made a mistake, you can then delete the vpnaas-service-delete-rebase-practice branch and try again.

Once you've got the vpnaas-service-delete branch rebased, you'll have to do a force push:

$ git push -f  simonre vpnaas-service-delete

During the code review, we don't want branches which were forced - only if a rebase is requested (like this).

Let me know if you need help and I'll rebase this on my side and provide the steps to walk you through it.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 07s
• gophercloud-acceptance-test : SUCCESS in 29m 20s

[simonre]

@jtopjian This should do it. Thanks for the in-depth answers and explanations. Really appreciate it!

[jtopjian]

@simonre Yes, perfect - nice work 😄