Vpnaas: List IPSec Policies #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
jtopjian
requested changes
Feb 22, 2018
| // the API. Filtering is achieved by passing in struct field values that map to | ||
| // the IPSec policy attributes you want to see returned. | ||
| type ListOpts struct { | ||
| ID string `q:"id"` |
There was a problem hiding this comment.
Same comment here as with the Services ListOpts.
| EncapsulationMode string `q:"encapsulation_mode"` | ||
| EncryptionAlgorithm string `q:"encryption_algorithm"` | ||
| PFS string `q:"pfs"` | ||
| Lifetime Lifetime `q:"lifetime"` |
There was a problem hiding this comment.
Is this actually possible to query with?
| "encapsulation_mode": "tunnel", | ||
| "encryption_algorithm": "aes-128", | ||
| "pfs": "group5", | ||
| "project_id": "b4eedccc6fb74fa8a7ad6b08382b852b", |
There was a problem hiding this comment.
Same comment as with the Services List PR. If both ProjectID and TenantID are being returned, let's make sure both are in the results struct.
simonre
changed the title
added 5 commits
February 27, 2018 10:58
simonre
force-pushed
the
vpnaas-ipsecpolicy-list
branch
from
6fa93ce
to
d35b4b5
Compare
|
Build succeeded.
|
simonre
changed the title
|
@jtopjian This is ready for review |
|
Build succeeded.
|
|
@simonre This looks good! Nice work on the list implementation. There are some nits in the |
jtopjian
approved these changes
Feb 28, 2018
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
This commit removes the flatmap package from tests since it has been deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #723
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L454