Network v2: RBAC-Delete #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
@jtopjian @kvrshenoy2 I request you both to review this PR. |
|
@PriyankaJ77 This looks good - nice work 😄 But there are some new conflicts from the previous merge that will need resolved. |
PriyankaJ77
force-pushed
the
rbac-delete
branch
from
3e400a2
to
1294600
Compare
|
Build succeeded.
|
|
@jtopjian resolved all the merge conflicts. |
|
Looks good to me - thank you! :) |
Merged
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
Add "qos_policy_id" attribute for "openstack_networking_port_v2" resource. Update tests and docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #731
Delete RBAC policy by ID.
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API:
https://developer.openstack.org/api-ref/network/v2/#delete-rbac-policy
Schema:
https://github.com/openstack/neutron/blob/8f79a92e45c84819cfc4d1cda99c9320ae78bbaf/neutron/db/rbac_db_models.py
Delete:
https://github.com/openstack/neutron/blob/59e2c40f14157e0f2f64c340070cf46758d522e1/neutron/db/rbac_db_mixin.py#L85