Vpnaas: Show IKE policy details #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
simonre
changed the title
simonre
force-pushed
the
vpnaas-ikepolicy-get
branch
from
2837bf2
to
25fd854
Compare
simonre
changed the title
|
Build succeeded.
|
simonre
changed the title
|
@jtopjian This is ready for review |
jtopjian
reviewed
Feb 28, 2018
| Example to Show the details of a specific IKE policy by ID | ||
|
|
||
| policy, err := ikepolicies.Get(client, "f2b08c1e-aa81-4668-8ae1-1401bcb0576c").Extract() | ||
| if err != nil { |
There was a problem hiding this comment.
Small nit to fix the indenting here. I'm going to go ahead and merge this since everything else is good, but could you fix this in a future PR?
This inline documentation will be displayed as the official documentation at godoc.org, so we want to make sure it's correct.
|
@simonre Looks good - thanks! Just one small doc nit for a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #723
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L367