Compute Acceptance Test Fixes #8

jtopjian · 2016-07-13T04:55:45Z

This PR enables individual compute acceptance tests to be run. Only a few acceptance tests are passing at this time, however, these changes are required for Go to validate the acceptance/openstack/compute/v2 package.

For #6

coveralls · 2016-07-13T04:58:23Z

Coverage remained the same at 89.876% when pulling 437a5fd on jtopjian:compute-acc-fixes into 6fb9d11 on gophercloud:master.

jtopjian · 2016-07-13T05:00:49Z

@jrperritt No doubt I'm jumping the gun on getting fixes/changes into this new repo, so please feel free to nit (or nix) all of this.

I began going through the compute acceptance tests and thought about compiling them all into one large PR, but it looks like that would be one very large PR. In addition, some of the test failures might require changes to the corresponding packages (see #7). So I thought I'd start with this which at least allows individual tests to be run.

jtopjian · 2016-07-24T16:20:13Z

@jrperritt Curiosity is getting the best of me and I've started going through each of the Compute acceptance tests to see what fixes they need or how I can practice cleaning them up. I have each of the above tests also in separate branches if that would be easier, but some require a few common fixes. I can look at making each branch completely standalone, though.

jtopjian · 2016-07-24T16:29:16Z

acceptance/openstack/compute/v2/servers_test.go

+	defer func() {
+		servers.Delete(client, server.ID)
+		t.Logf("Server deleted.")
+	}()


I've moved the delete defer to be triggered after the instance has been confirmed ACTIVE. This is so if instance creation fails, the error'd instance still remains so the tester can investigate why the instance failed to launch. When defer was in its original location, the instance would immediately be deleted, the UUID never printed (though this can be fixed), and troubleshooting was much harder.

jrperritt · 2016-07-25T19:10:41Z

As far as I'm concerned, you can't make the acceptance tests any worse than they were before this PR. Because of that, As long as you're only touching the acceptance tests (or docs), I'm not concerned about reviewing this (and therefore not concerned about the size of it). Once you're happy with it (and it builds), let me know and I'll merge it.

jtopjian · 2016-07-25T19:13:01Z

As far as I'm concerned, you can't make the acceptance tests any worse than they were before this PR.

I'm gonna take that as a compliment :D

Sounds good. This has been pretty fun and a good way for me to determine what needs to be (or can be, for the better) changed in Terraform.

jrperritt · 2016-07-25T19:18:55Z

I'm gonna take that as a compliment :D

It was, and a slight to myself.

coveralls · 2016-07-26T02:55:19Z

Coverage remained the same at 89.876% when pulling 260f698 on jtopjian:compute-acc-fixes into 4b4827b on gophercloud:master.

jtopjian · 2016-07-26T02:57:25Z

@jrperritt I think this is ready to go!

There are probably a few nits here and there and I wasn't able to successfully run the defsecrules tests due to that extension requiring a custom environment, but other than that, everything runs great!

Let me know if you have any questions.

jrperritt · 2016-07-26T16:14:23Z

script/acceptancetest_environments/keystonev2-lbaasv1.sh

@@ -0,0 +1,153 @@
+#!/bin/bash


Did you mean for this to be committed, and, if so, can you comment on what it does? Something like # Installs keylogger would suffice.

Yup, meant to commit it, but oops on not having any useful comments.

jrperritt · 2016-07-26T16:15:18Z

Can you merge or rebase with master? After that and that ^, this looks good to merge.

The following changes were made to the common compute acc test functions: * Check for Instances in ERROR state to immediately return. * Making OS_POOL_NAME required. * Added identity client function. * Added block storage client function. * Making "private" the default OS_NETWORK_NAME.

The following changes were made to the flavor acceptance test: * Renamed tests so tests can selectively be run by substring * Reading all returned pages at once. * Modified test output. * Printing all flavor attributes.

The following changes were made to the image acceptance test: * Added test to get a single image. * Renamed tests so tests can selectively be run by substring * Reading all returned pages at once. * Modified test output. * Printing all image attributes.

The following changes were made to the servers acceptance tests: * Renamed tests so tests can selectively be run by substring. * Reading all returned pages at once. * Modified test output. * Printing all server attributes in output. * Consistently place and log server deletion. * Fixed occurrences of wrong error variable being reported. * Removed invalid resize error. * Implemented RebootOpts in order to test server reboot.

The following changes were made to the servergroups acceptance tests: * Renamed servers to servergroups in build tag * Renamed tests so tests can selectively be run by substring. * Modified test output. * Printing all servergroups attributes.

The following changes were made to the keypairs acceptance tests: * Added build tags. * Added List test. * Added Create test. * Added Import test. * Cleaned up Server Create test. * Printing all keypairs attributes.

The following changes were made to the security groups acceptance tests: * Created List test. * Broke out Create, Update, and Rule tests. * Printing all security group attributes. * Renamed AddServerToGroup to AddServer. * Renamed RemoveServerFromGroup to RemoveServer.

The following changes were made to the floating IPs acceptance test: * Renamed package floatingip to floatingips. * Created List test. * Broke out Create, Associate, and Associate Fixed IP tests. * Removed deprecated associate tests. * Printing all floating IP attributes.

The following changes were made to the tenant networks acceptance tests: * Created List test. * Created Get test. * Removed server test. * Printing all tenant network attributes.

The following changes were made to the networks acceptance tests: * Created List test. * Created Get test. * Removed server test. * Printing all network attributes.

The following changes were made to the extensions acceptance tests: * Retrieving all extensions with all pages. * Fixed build tag. * Renamed tests so tests can selectively be run by substring. * Printing all extension attributes.

The following changes were made to the quota sets acceptance tests: * Added build tag. * Renamed tests so tests can selectively be run by substring. * Now obtaining identityclient via common compute acctest function.

The following changes were made to the defsecrules acceptance tests: * Renamed tests so tests can selectively be run by substring. * Retrieving lists with all pages. * Renamed test file. * Printing all default rule attributes.

The following changes were made to the bootfromvolume acceptance tests: * Renamed tests so tests can selectively be run by substring. * Created createBootFromVolumeServer function

The following changes were amde to the volumeattach acceptance tests: * Added build tag. * Obtaining block storage client from common function. * Printing all volume attachment attributes.

* Removed Rackspace-specific environment variables. * Added OS_POOL_NAME environment variable. * Added OS_NETWORK_NAME environment variable. * Added bash function for test shortcuts. * Added notes about compute tests.

This script will install devstack and Go within a virtual machine. Devstack is configured with the current API versions of all OpenStack services except for Keystone (v2) and LBaaS (v1).

jtopjian · 2016-07-26T16:50:07Z

@jrperritt Done and done.

coveralls · 2016-07-26T16:50:44Z

Coverage remained the same at 89.876% when pulling e361ee8 on jtopjian:compute-acc-fixes into b1ac8fd on gophercloud:master.

jrperritt · 2016-07-26T17:41:28Z

Thank you for all the work on this. +2

jtopjian · 2016-07-26T17:50:05Z

Thank you for all the work on this.

No problem at all. I'll probably go through a few of the others that I'm familiar with (block storage, networking).

jtopjian changed the title ~~[wip] Compute Acceptance Test Fixes~~ Compute Acceptance Test Fixes Jul 13, 2016

jtopjian changed the title ~~Compute Acceptance Test Fixes~~ [wip] Compute Acceptance Test Fixes Jul 24, 2016

jtopjian force-pushed the compute-acc-fixes branch from 437a5fd to d493d0b Compare July 24, 2016 16:17

jtopjian reviewed Jul 24, 2016
View reviewed changes

jtopjian force-pushed the compute-acc-fixes branch 3 times, most recently from d5b244a to 49f9007 Compare July 25, 2016 16:45

jtopjian force-pushed the compute-acc-fixes branch 2 times, most recently from 8df0cb1 to 260f698 Compare July 26, 2016 02:52

jtopjian changed the title ~~[wip] Compute Acceptance Test Fixes~~ Compute Acceptance Test Fixes Jul 26, 2016

jrperritt reviewed Jul 26, 2016
View reviewed changes

jtopjian added 8 commits July 26, 2016 16:46

Flavor Acceptance Test Cleanup

8349dfa

The following changes were made to the flavor acceptance test: * Renamed tests so tests can selectively be run by substring * Reading all returned pages at once. * Modified test output. * Printing all flavor attributes.

Image Acceptance Test Cleanup

8831011

The following changes were made to the image acceptance test: * Added test to get a single image. * Renamed tests so tests can selectively be run by substring * Reading all returned pages at once. * Modified test output. * Printing all image attributes.

Server Group Acceptance Test Cleanup

6aa8ba0

The following changes were made to the servergroups acceptance tests: * Renamed servers to servergroups in build tag * Renamed tests so tests can selectively be run by substring. * Modified test output. * Printing all servergroups attributes.

Key Pairs Acceptance Test Cleanup

c382078

The following changes were made to the keypairs acceptance tests: * Added build tags. * Added List test. * Added Create test. * Added Import test. * Cleaned up Server Create test. * Printing all keypairs attributes.

jtopjian added 11 commits July 26, 2016 16:46

Tenant Networks Acceptance Test Cleanup

5346c00

The following changes were made to the tenant networks acceptance tests: * Created List test. * Created Get test. * Removed server test. * Printing all tenant network attributes.

Compute Networks Acceptance Test Cleanup

924f701

The following changes were made to the networks acceptance tests: * Created List test. * Created Get test. * Removed server test. * Printing all network attributes.

Extensions Acceptance Test Cleanup

59c5783

The following changes were made to the extensions acceptance tests: * Retrieving all extensions with all pages. * Fixed build tag. * Renamed tests so tests can selectively be run by substring. * Printing all extension attributes.

QuotaSets Acceptance Test Cleanup

713e51a

The following changes were made to the quota sets acceptance tests: * Added build tag. * Renamed tests so tests can selectively be run by substring. * Now obtaining identityclient via common compute acctest function.

Default SecGroup Rules Acceptance Test Cleanup

aa8aff1

The following changes were made to the defsecrules acceptance tests: * Renamed tests so tests can selectively be run by substring. * Retrieving lists with all pages. * Renamed test file. * Printing all default rule attributes.

Boot From Volume Acceptance Test Cleanup

aa8e5e3

The following changes were made to the bootfromvolume acceptance tests: * Renamed tests so tests can selectively be run by substring. * Created createBootFromVolumeServer function

Volume Attach Acceptance Test Cleanup

ab883ea

The following changes were amde to the volumeattach acceptance tests: * Added build tag. * Obtaining block storage client from common function. * Printing all volume attachment attributes.

Updated acceptance test README

0dd4487

* Removed Rackspace-specific environment variables. * Added OS_POOL_NAME environment variable. * Added OS_NETWORK_NAME environment variable. * Added bash function for test shortcuts. * Added notes about compute tests.

Script to build devstack acceptance test environment

4b6ce84

This script will install devstack and Go within a virtual machine. Devstack is configured with the current API versions of all OpenStack services except for Keystone (v2) and LBaaS (v1).

Added MIGRATING notes

0ce32ca

Added description of devstack acceptance test environment script

e361ee8

jtopjian force-pushed the compute-acc-fixes branch from 260f698 to e361ee8 Compare July 26, 2016 16:47

jrperritt merged commit 6b427a5 into gophercloud:master Jul 26, 2016

jrperritt mentioned this pull request Jul 26, 2016

Compute Acceptance Test Issues #6

Closed

jtopjian deleted the compute-acc-fixes branch March 23, 2017 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compute Acceptance Test Fixes #8

Compute Acceptance Test Fixes #8

jtopjian commented Jul 13, 2016

coveralls commented Jul 13, 2016 •

edited

Loading

jtopjian commented Jul 13, 2016

jtopjian commented Jul 24, 2016

jtopjian Jul 24, 2016

jrperritt commented Jul 25, 2016

jtopjian commented Jul 25, 2016

jrperritt commented Jul 25, 2016

coveralls commented Jul 26, 2016 •

edited

Loading

jtopjian commented Jul 26, 2016

jrperritt Jul 26, 2016

jtopjian Jul 26, 2016

jrperritt commented Jul 26, 2016

jtopjian commented Jul 26, 2016

coveralls commented Jul 26, 2016 •

edited

Loading

jrperritt commented Jul 26, 2016

jtopjian commented Jul 26, 2016

Compute Acceptance Test Fixes #8

Compute Acceptance Test Fixes #8

Conversation

jtopjian commented Jul 13, 2016

coveralls commented Jul 13, 2016 • edited Loading

jtopjian commented Jul 13, 2016

jtopjian commented Jul 24, 2016

jtopjian Jul 24, 2016

Choose a reason for hiding this comment

jrperritt commented Jul 25, 2016

jtopjian commented Jul 25, 2016

jrperritt commented Jul 25, 2016

coveralls commented Jul 26, 2016 • edited Loading

jtopjian commented Jul 26, 2016

jrperritt Jul 26, 2016

Choose a reason for hiding this comment

jtopjian Jul 26, 2016

Choose a reason for hiding this comment

jrperritt commented Jul 26, 2016

jtopjian commented Jul 26, 2016

coveralls commented Jul 26, 2016 • edited Loading

jrperritt commented Jul 26, 2016

jtopjian commented Jul 26, 2016

coveralls commented Jul 13, 2016 •

edited

Loading

coveralls commented Jul 26, 2016 •

edited

Loading

coveralls commented Jul 26, 2016 •

edited

Loading