Networking v2: Support both TenantID and ProjectID where applicable #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #790
Per discussion in #790, this PR adds
ProjectIDsupport to the network resources which support it.I've updated the inline documentation where applicable, notably rewording
TenantIDto be described as a "project". My intention was to imply that tenant and project are the same without having a paragraph in each resource explicitly laying that out.This has been tested to the best of my ability. There's always a chance something slipped by me.
/cc @dklyle
edit: In #790 I mentioned that LBaaS does not send
project_id. To amend that statement, LBaaS will gladly acceptProjectIDin other calls. It just does not set it in the response.