-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vpnaas: List Endpoint groups #813
Conversation
Build succeeded.
|
@jtopjian This is ready for review. I'm not sure if this is the right place to ask this but I noticed that you are a maintainer for terraform-provider-openstack as well. I'm planning to implement the VPNaas functionality in the openstack provider as well but I couldn't find any contributing guide. Anything I need to know before making a pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonre Looks good - just one minor change request.
// the API. Filtering is achieved by passing in struct field values that map to | ||
// the Endpoint group attributes you want to see returned. | ||
type ListOpts struct { | ||
TenantID string `q:"tenant_id"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add ProjectID
as well.
Adding VPNaaS to Terraform would be much appreciated! Creating a Terraform resource is pretty straightforward, but let me know if you need help. As far as contributing guidelines/rules:
The best way to get started is to copy an existing resource and start renaming things. Terraform resources are pretty easy to create since the functions you need to implement match very well with CRUD. Implementing Terraform resources can sometimes uncover bugs we didn't catch in Gophercloud. That's totally OK - just open a Gophercloud Issue and PR with a patch. In fact, Terraform is sometimes a great way to debug Gophercloud because you can do: $ OS_DEBUG=1 TF_LOG=DEBUG terraform apply And see the full API interaction. I've been meaning to add this functionality to the Gophercloud acceptance tests. Feel free to open a PR and we'll work on it together. :) |
@jtopjian I've implemented the change so this is ready for review again. Once again thank you for the in-depth answer. It's a pleasure to work with you on this. |
Build succeeded.
|
LGTM! |
For #723
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L626