Vpnaas: List Endpoint groups

[simonre]

For #723

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L626

[coveralls]

Coverage increased (+0.04%) to 73.772% when pulling c6e404e on simonre:vpnaas-epgroup-list into c3bc092 on gophercloud:master.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 10m 01s
• gophercloud-acceptance-test : SUCCESS in 52m 42s

[simonre]

@jtopjian This is ready for review.

I'm not sure if this is the right place to ask this but I noticed that you are a maintainer for terraform-provider-openstack as well. I'm planning to implement the VPNaas functionality in the openstack provider as well but I couldn't find any contributing guide. Anything I need to know before making a pull request?

[jtopjian]

@simonre Looks good - just one minor change request.

[jtopjian]

Let's add ProjectID as well.

[jtopjian]

@simonre

I'm not sure if this is the right place to ask this but I noticed that you are a maintainer for terraform-provider-openstack as well. I'm planning to implement the VPNaas functionality in the openstack provider as well but I couldn't find any contributing guide. Anything I need to know before making a pull request?

Adding VPNaaS to Terraform would be much appreciated! Creating a Terraform resource is pretty straightforward, but let me know if you need help.

As far as contributing guidelines/rules:

1. One resource or data source per PR, please. For example one PR would contain the implementation of openstack_vpnaas_ipsec_policy_v2. The PR can contain a fully functional resource (so full CRUD).

2. It works best if you can do two commits: one with the vendoring (Terraform uses govendor) and one with the squashed commits of the resource (so the entire commit would be "adding openstack_vpnaas_ipsec_policy_v2"). The same rule applies about only amending commits if changes are needed, though, and if that happens, don't worry about having more than two commits.

3. Acceptance tests are important but we won't be able to run them in the CI system, so two things to note:

   a. We'll trust that you've run the tests and they're successful.
   b. Restrict the tests to be triggered via an environment variable like here:

   • https://github.com/terraform-providers/terraform-provider-openstack/blob/master/openstack/resource_openstack_dns_recordset_v2_test.go#L24
   • https://github.com/terraform-providers/terraform-provider-openstack/blob/master/openstack/provider_test.go#L88-L94

4. Docs are also important, too. They are housed under the website directory of the repo.

5. If you don't plan on implementing the ability to import the resource, make sure you omit these lines:

   https://github.com/terraform-providers/terraform-provider-openstack/blob/master/openstack/resource_openstack_dns_recordset_v2.go#L22-L24

   If you do want to implement importing, make sure to include a separate file like this:

   https://github.com/terraform-providers/terraform-provider-openstack/blob/master/openstack/import_openstack_dns_recordset_v2_test.go

The best way to get started is to copy an existing resource and start renaming things. Terraform resources are pretty easy to create since the functions you need to implement match very well with CRUD.

Implementing Terraform resources can sometimes uncover bugs we didn't catch in Gophercloud. That's totally OK - just open a Gophercloud Issue and PR with a patch.

In fact, Terraform is sometimes a great way to debug Gophercloud because you can do:

$ OS_DEBUG=1 TF_LOG=DEBUG terraform apply

And see the full API interaction. I've been meaning to add this functionality to the Gophercloud acceptance tests.

Feel free to open a PR and we'll work on it together. :)

[simonre]

@jtopjian I've implemented the change so this is ready for review again.

Once again thank you for the in-depth answer. It's a pleasure to work with you on this.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 12s
• gophercloud-acceptance-test : SUCCESS in 30m 38s

[jtopjian]

LGTM!