Compute v2: Fix EOF errors in compute secgroups #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
I've confirmed that, with our OpenStack system, this fix solves the EOF problem we were encountering. |
dklyle
approved these changes
Mar 14, 2018
jrperritt
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #206
This commit modifies the
AddServerandRemoveServeractions so a response body is not parsed.I'll admit I haven't done an exhaustive review of the code, but from what I can tell, the lack of a return statement here:
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/security_groups.py#L441-L456
Is probably good enough.
Note how other functions are returning some object, such as here:
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/security_groups.py#L340
Also note that the explicit EOF check in the acceptance test was added by me (which I'm removing in this PR). This is because I swear I was seeing intermittent EOFs and not steady ones. But it's been so long since I was working on that, I can't be sure if my testing was correct.
/cc @dklyle