Acc Compute v2: Updating the Compute v2 Acceptance Tests

[jtopjian]

For #818

[coveralls]

Coverage remained the same at 73.825% when pulling ccd20d9 on jtopjian:acc-compute-updates into 35000af on gophercloud:master.

[theopenlab-ci]

Build failed.

• gophercloud-unittest : SUCCESS in 2m 30s
• gophercloud-acceptance-test : POST_FAILURE in 2h 22m 56s

[jtopjian]

This is ready for review.

There's a lot going on here, but the changes generally fall under the following categories:

1. Addition of AssertEquals in various places. There aren't checks for everything but it's a good start and definitely enough to have more confidence in the acceptance testing.

2. Addition of RequiresX convenience functions: https://github.com/jtopjian/gophercloud/blob/947904130a9773785edd1b726a727839cd2bf27f/acceptance/clients/conditions.go

   These are pretty handy and add some nice-looking declarations to the tests: https://github.com/jtopjian/gophercloud/blob/947904130a9773785edd1b726a727839cd2bf27f/acceptance/openstack/compute/v2/migrate_test.go#L30

   These functions are key to getting the entire acceptance suite into OpenLab.

3. General cleanup where it was obvious to do so.

4. Removal of verbose error messages: 9479041

   This was intentionally done as the last commit so I could easily nix it if requested. On one hand, the verbose error messages make the acceptance tests useful reference examples. On the other hand, omitting them makes the tests smaller and easier to write (thus more appealing to contributors).

This PR also includes #819 since I found it handy for my own debugging here.

Happy to make any changes as requested.

/cc @dklyle

edit: given the amount of green/red diffs in each file, I recommend looking at the finished files. They're quite clean and streamlined. :)

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 5m 40s
• gophercloud-acceptance-test : SUCCESS in 27m 24s

[jtopjian]

Merge conflict has been resolved.

I should have been more clear with my previous comment: I don't expect anyone to review each and every change here. This is a bulk update to the compute acceptance tests and if I was only adding a bunch of AssertEquals statements, I'd be comfortable merging them on my own.

But I'd like to get feedback / signoffs on:

1. The checks added to conditions.go
2. The removal of all of the t.Logf statements.

If both of those are acceptable, I'm going to go through the rest of the tests and make similar changes in bulk.

If those items shouldn't be added or need changed, I'll make them here and then proceed with the other tests in a similar fashion.

[theopenlab-ci]

Build succeeded.

• gophercloud-unittest : SUCCESS in 2m 40s
• gophercloud-acceptance-test : SUCCESS in 27m 43s

[jrperritt]

Yep, this all looks reasonable to me