LBaaS v2 l7 policy support - part 2: list l7policy #835
Conversation
|
@jtopjian before i continue, could you please tell me if i'm on the right way? |
|
Build succeeded.
|
|
this patch is ready for review, @jtopjian @jrperritt @dklyle |
lingxiankong
force-pushed
the
octavia-l7-policy-list
branch
from
106852d
to
02b9a0c
Compare
|
Build succeeded.
|
lingxiankong
force-pushed
the
octavia-l7-policy-list
branch
from
02b9a0c
to
5b7ce47
Compare
|
Build succeeded.
|
lingxiankong
force-pushed
the
octavia-l7-policy-list
branch
from
5b7ce47
to
e1363e1
Compare
|
Build succeeded.
|
lingxiankong
force-pushed
the
octavia-l7-policy-list
branch
from
e1363e1
to
c21254c
Compare
|
Build succeeded.
|
lingxiankong
changed the title
|
@jtopjian hi, i'm not sure if the ci failure relates to my change, how can i retrigger? |
For gophercloud#832 Neutron-LBaaS l7 policy list API implementation: https://github.com/openstack/neutron-lbaas/blob/8e8a6c47c7d38fa7b61850ff9ea2cf130718ded3/neutron_lbaas/services/loadbalancer/plugin.py#L967 Octavia l7 policy list API implementation: https://github.com/openstack/octavia/blob/54a4cf00cf304b108013ca4487c138c13f30983d/octavia/api/v2/controllers/l7policy.py#L61
lingxiankong
force-pushed
the
octavia-l7-policy-list
branch
from
c21254c
to
4b59796
Compare
|
Build succeeded.
|
|
@lingxiankong We had a fun day of test failures today :) The Travis failures were fixed here: #892. I believe only myself or @jrperritt can retrigger those. The OpenLab failures should be resolved with #890. If you want to re-run them, you can make a comment with the single word of |
|
@jtopjian @jrperritt ping for review. I rebased the commit now all CI tests are green. |
There was a problem hiding this comment.
@lingxiankong Looks good to me! Thank you again for your patience.
The two nits are non-blocking. Would you be able to fix them in the next PR?
| @@ -12,5 +12,21 @@ Example to Create a L7Policy | |||
| if err != nil { | |||
| panic(err) | |||
| } | |||
|
|
|||
| Example to List L7Policies | |||
There was a problem hiding this comment.
nit: Doc headers need to have a newline before and after. Same for the "Example to Create a L7Policy" header.
For #832
Octavia L7 policy list API:
https://developer.openstack.org/api-ref/load-balancer/v2/index.html#list-l7-policies