Vpnaas: Update Site connection #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonre
changed the title
|
@jtopjian This is ready for review |
simonre
changed the title
|
LGTM! |
problemv
pushed a commit
to problemv/gophercloud
that referenced
this pull request
Apr 4, 2018
* Added update function and unit test * Changed strings to pointers in documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #723
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-vpnaas/blob/058469e1b99b647537a5228c6a384d93df5484df/neutron_vpnaas/db/vpn/vpn_db.py#L202
https://github.com/openstack/neutron-vpnaas/blob/871d933bf1645aed2185f92a80cfe6ba642618eb/neutron_vpnaas/extensions/vpnaas.py#L236
I also put some doc fixes for IKE and IPSec policies in there, hope that's ok.
This PR does not contain acceptance tests as discussed in #784